microsoft/microsoft-ui-xaml

Control Styles should be named

Open

#3,735 创建于 2020年12月1日

在 GitHub 查看
 (16 评论) (1 反应) (0 负责人)C# (5,815 star) (659 fork)batch import
area-Stylinghelp wantedteam-Controlswct

描述

While investigating this, I noticed an issue for this that is a complete show stopper: there is no way to override the default TabViewItem style. Unlike some other controls, the TabViewItem does not follow the pattern of:

<Style TargetType="ControlName" BasedOn="DefaultControlNameStyle"/>

<Style x:Key="DefaultControlNameStyle" TargetType="ControlName">
...
</Style>

but rather just exposes the complete template as the default style leaving users with no choice of easily overriding the default style. However that is something that we would need for this feature to be easily usable. @ranjeshj @stmoy @StephenLPeters Is that something we can change to make that customization easier?

@michael-hawker FYI

Originally posted by @chingucoding in https://github.com/microsoft/microsoft-ui-xaml/issues/2587#issuecomment-732463534

贡献者指南

技术栈
csharp
领域
desktopfrontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
XAML stylingWinUI controlsC# basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the current default style pattern for TabViewItem and other controls in the repository. Identify where default styles are defined (likely in generic.xaml). Propose a change to follow the 'DefaultControlNameStyle' pattern as used by other controls, ensuring backward compatibility. Consult maintainers @ranjeshj, @stmoy, @StephenLPets for guidelines on naming conventions.