(1 评论) (0 反应) (0 负责人)C++ (3,212 fork)batch import

Area-CodeHealthHelp WantedIssue-TaskPriority-3Product-Conhost

仓库指标

Star: (35,764 star)
PR 合并指标: (平均合并 27天 19小时) (30 天内合并 24 个 PR)

描述

Environment

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] 10.0.19041.388
Windows Terminal version (if applicable): 1.0.1811.0 + recent preview

In #4493 @miniksa pointed out that the state should be a member of SCREEN_INFORMATION rather than a static variable in WriteConsoleAImpl. Refer to https://github.com/microsoft/terminal/pull/4493#discussion_r389024806 In the current code base it's still in WriteConsoleAImpl though. https://github.com/microsoft/terminal/blob/d0ff5f6b5e7687c438e0a8b120280be307eda778/src/host/_stream.cpp#L1107 Since I closed the PR I just don't want this information to get lost.

贡献者指南

研究方向: 参考PR讨论#4493和当前代码src/host/ stream.cpp。将静态变量u8State从WriteConsoleAImpl移动到SCREEN INFORMATION类，确保更新所有引用。
技术栈: cpp
领域: backend
议题类型: 重构
难度: 2
预计时间: 1-3 小时
活动状态: 活跃
清晰度: 清晰
前置要求: C++
新手友好度: 75