microsoft/Terminal

Investigate include order issue with `InputBuffer`, `readData`

Open

#4,262 创建于 2020年1月16日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)C++ (3,212 fork)batch import
Area-CodeHealthHelp WantedIssue-TaskPriority-3Product-Conhost

仓库指标

Star
 (35,764 star)
PR 合并指标
 (平均合并 27天 19小时) (30 天内合并 24 个 PR)

描述

Found in #4213.

I had to fwddecl InputBuffer, because I think there's a include order problem with in InputBuffer.hpp and readData.hpp.

readData.hpp uses InputBuffer in a bunch of places, but doesn't include it first

InputBuffer.hpp includes readData.hpp before it defines InputBuffer

So if you try to

#include ".../host/inputBuffer.hpp"

You'll get a compilation error, because it'll include readData, which will assume InputBuffer is defined, which it isn't yet.

贡献者指南