microsoft/Terminal

Code Health: Update existing winrt properties to use `GETSET_PROPERTY` when possible

Open

#3,988 创建于 2019年12月17日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)C++ (3,212 fork)batch import
Area-CodeHealthHelp WantedIssue-TaskProduct-Terminal

仓库指标

Star
 (35,764 star)
PR 合并指标
 (平均合并 27天 19小时) (30 天内合并 24 个 PR)

描述

Pretty self explanatory. Classes with a bunch of


    uint32_t TerminalSettings::DefaultForeground()
    {
        return _defaultForeground;
    }

    void TerminalSettings::DefaultForeground(uint32_t value)
    {
        _defaultForeground = value;
    }

Is an enormous amount of boilerplate we don't need.

GETSET_PROPERTY(uint32_t, DefaultForeground, DEFAULT_FOREGROUND_WITH_ALPHA);

is better.

贡献者指南