microsoft/Terminal

Use default page transition for settings pages instead of drill-in transition

Open

#16,292 创建于 2023年11月11日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)C++ (3,212 fork)batch import
Area-SettingsUIHelp WantedIssue-TaskProduct-Terminal

仓库指标

Star
 (35,764 star)
PR 合并指标
 (平均合并 27天 19小时) (30 天内合并 24 个 PR)

描述

Description of the new feature/enhancement

The settings content frame currently specifies DrillInNavigationTransitionInfo as content transition mode: https://github.com/microsoft/terminal/blob/d14524cd4cc4970bb1b6456f9667e2dd661b9854/src/cascadia/TerminalSettingsEditor/MainPage.xaml#L179

The drill-in effect, as its name suggests, is in my opinion suitable when navigating further down in a hierarchy (e.g. viewing a list of folders and navigating into a subfolder) but less appropriate when switching between settings pages which are on the same logical level.

Instead, I suggest to use the default page transition mode "slide from bottom", which is also used in the Windows Settings, and whose UI is very similar to the settings in Windows Terminal. By using the same transitions, Windows Terminal will feel more consistent with the inbuilt OS apps.

Proposed technical implementation details (optional)

Replace lines https://github.com/microsoft/terminal/blob/d14524cd4cc4970bb1b6456f9667e2dd661b9854/src/cascadia/TerminalSettingsEditor/MainPage.xaml#L177-L181 with

<NavigationThemeTransition />

(There is a difference between specifying <NavigationThemeTransition /> and not setting Frame.ContentTransitions at all. If it is not set at all, the Frame will still use the "slide from bottom" transition between page transitions as a default but it will not show the animation on initial displaying of the page. Since the Windows Settings app does show an animation on initial loading of the page, my suggestion is to do it here, as well.)

贡献者指南