microsoft/Terminal

Refactor `_GetProposedFont` into a static function

Open

#11,763 创建于 2021年11月15日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)C++ (3,212 fork)batch import
Area-CodeHealthArea-PerformanceHelp WantedIssue-TaskPriority-2Product-Terminal

仓库指标

Star
 (35,764 star)
PR 合并指标
 (平均合并 27天 19小时) (30 天内合并 24 个 PR)

描述

Ported from MSFT-21254947

With Dart/OpenConsole!3129098, I instantiate an entire DxEngine just to get the initial size of the control.

Turns out there's only two things that _GetProposedFont really needs from the instance - the dwriteFactory, and the _chainMode. If we make those params, then we could make GetProposedFont a public static function, and not need to instantiate an entire engine (including all the dx resources it needs) just to get the font size.

We should not be spinning up an entire DX Renderer to ask it how big a cell should be.

贡献者指南