microsoft/RecursiveExtractor

Improve tests to validate the correct contents of extracted files

Open

#104 创建于 2022年12月20日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)C# (36 fork)auto 404
enhancementgood first issuetest

仓库指标

Star
 (218 star)
PR 合并指标
 (PR 指标待抓取)

描述

Currently the tests primarily check that the correct number of files are returned from extraction commands. However, as the issue identified in #102 shows this can be insufficient in cases where the underlying library may not be threadsafe (for example). In such cases the tests can still succeed, finding the correct number of files, but their contents may be incomplete. We should develop additional tests that verify for each file type we support that the contents + sizes of each file are correct. Perhaps the easiest method would be with a hash of the contents of the extracted stream.

贡献者指南