micrometer-metrics/micrometer

DNS, SSL, and TCP metrics for Apache HttpClient

Closed

#1,617 创建于 2019年10月1日

在 GitHub 查看
 (5 评论) (0 反应) (1 负责人)Java (4,220 star) (935 fork)batch import
enhancementhelp wantedinstrumentationmodule: micrometer-core

描述

Add metrics for:

  1. DNS resolution time (inject custom DnsResolver, delegating to the user-provided resolver, and timing).
  2. SSL handshake time (inject SSLConnectionSocketFactory, delegating).
  3. TCP connect time (also in custom SSLConnectionSocketFactory).

Apply these on custom PoolingHttpClientConnectionManager.

Feedback suggests that DNS resolution/SSL handshake can go up dramatically in noisy neighbor situations.

Originally posted by @jkschneider in https://github.com/micrometer-metrics/micrometer/issues/533#issuecomment-446713248

贡献者指南

技术栈
java
领域
observability
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaApache HttpClientMicrometerSSL/TLS basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Investigate injecting custom DnsResolver and SSLConnectionSocketFactory into PoolingHttpClientConnectionManager. Review Apache HttpClient documentation for hooks. Examine existing Micrometer instrumentation patterns for timing using Timer. Consider the noisy neighbor scenario mentioned in the issue. Look at the original comment by jkschneider for context.