micro-analytics/micro-analytics-cli

Connection leaks in adapter tests

Open

#75 创建于 2017年6月29日

在 GitHub 查看
 (0 评论) (1 反应) (0 负责人)JavaScript (52 fork)batch import
adapter-testshelp wanted

仓库指标

Star
 (738 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

The adapter tests does not close connection correctly resulting in tests for the redis adapter never quitting.

The problem is the at the moment is call init should not throw. Overwrites the connections with new one and then when the tests closes connection in afterEach the connection created in beforeEach is not closed.

I think it would be a good thing to require adapter.close() and handle the closing of database connections in the adapter utils.

贡献者指南