mholt/PapaParse

preview + step never completes

Open

#618 创建于 2019年1月21日

在 GitHub 查看
 (3 评论) (3 反应) (0 负责人)JavaScript (11,877 star) (1,157 fork)batch import
help wanted

描述

The discussion (in #352) and the docs indicate that the meta.truncated value should become true when the last row to preview is parsed. But it doesn't it remains false and complete is never called. This means short of keeping your own counter there is no way to know that preview has completed.

To repro:

  • Go to the demo.
  • Select local file.
  • check Stream option.
  • Set preview to any positive non-zero value
  • Click parse
  • Nothing ever shows up in the console

贡献者指南

技术栈
javascript
领域
data
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with PapaParse's streaming API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the step callback implementation in PapaParse's source code. Look at how `meta.truncated` is set when using the preview option. Review the discussion in issue #352 for expected behavior. Implement the fix to set `meta.truncated = true` when the preview row limit is reached and ensure the complete callback is called.