mgechev/revive

Replace existing tests that target unexported functions with tests for exported

Open

#1,362 创建于 2025年5月20日

在 GitHub 查看
 (7 评论) (1 反应) (1 负责人)Go (316 fork)github user discovery
good first issuehelp wantedlow priority

仓库指标

Star
 (5,517 star)
PR 合并指标
 (PR 指标待抓取)

描述

From https://github.com/mgechev/revive/pull/1353#issuecomment-2887129427:

I'm not sure we should test unexported functions. They are internals and a matter to be freely changed with the refactoring. Testing them makes code less flexible for refactoring and tests more fragile. In my current project, for example, we have this strongly discouraged (with some legacy exceptions).

To improve test structure and enforce better package boundaries, we should refactor our current test suite:

  1. Replace existing tests that target unexported functions with equivalent tests targeting exported functions. Ensure the functionality is still covered by indirectly testing through public APIs.
  2. Adopt _test package convention.
  3. Enable testpackage linter in the golangci-lint config.

贡献者指南