metosin/reitit

Bundled CORS-support

Open

#236 创建于 2019年3月11日

在 GitHub 查看
 (9 评论) (22 反应) (0 负责人)Clojure (1,569 star) (261 fork)batch import
enhancementhelp wanted

描述

Currently, a third party mw/interceptor is needed for CORS. There should be a fast default mw & interceptor for this. Those could be configured either via route data or via mw/interceptor options. Example data format from https://github.com/metosin/reitit/issues/143#issuecomment-422079662:

{:access-control
 {:allow-origin "http://foo.example"
  :allow-methods #{:get :post :put}
  :allow-credentials true
  :allow-headers #{"X-PINGOTHER" "Content-Type"}
  :expose-headers #{"X-My-Custom-Header" "X-Another-Custom-Header"}
  :max-age 86400}}

Some prior work:

Related issues:

贡献者指南

技术栈
无
领域
backendapisecurity
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ClojureRing middlewareCORS protocol
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Examine the existing middleware implementation in reitit (e.g., reitit ring/src/reitit/ring.clj). Review the ring cors library (https://github.com/r0man/ring cors) and the Pedestal CORS implementation for patterns. Implement a new middleware that accepts options as shown in the example. Ensure it follows the reitit interceptor/middleware pattern and can be configured per route. The linked issues #143 and #85 contain additional discussion on expected behavior.