metosin/malli

Metadata-defined function schemas do not get reinstrumented by malli.dev

Open

#861 创建于 2023年3月5日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)Clojure (1,724 star) (237 fork)batch import
bughelp wanted

描述

Hello :wave:

I have noticed that functions schemas defined with metadata do not get reinstrumented by malli.dev on namespace reload. Any change to the file and namespace reload causes instrumentation to stop working.

This issue does not happen when a function is instrumented with malli.core/=>.

See the video showing this happening on the newest [metosin/malli "0.10.2"]:

https://user-images.githubusercontent.com/4920654/222991613-2e22a9ef-faf9-4e94-91d6-0c7aed07a572.mov

I'm not sure if it's just a bug or a known limitation but it takes away the dev utility of metadata schemas.

Let me know if I could help you with fixing it and big thank you for the library and those dev instrumentation features!

贡献者指南

技术栈
无
领域
developer experiencetooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Clojure basicsunderstanding of malli instrumentation
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
15
研究方向
Investigate the difference in reinstrumentation behavior between metadata defined function schemas and those defined with malli.core/=>. Focus on the malli.dev namespace and the function schemas.md documentation. Check the source code for how metadata based schemas are registered and why they are not reinstrumented on namespace reload. Look at related issues or PRs for context.