More friendly explanation for `:malli.core/invalid-type` · metosin/malli#750

2022-09-05T16:36:05.000Z

Hi! The following: ```clj (malli.error/humanize (malli.core/explain [:sequential :string] #{"a"})) ``` returns `"invalid-type"`. That could be improved in a couple ways: * it could say `expected :sequential, got :set` * i.e. mention the two specific types involved in the type mismatch. * additionally, or instead (for agility's sake), say `there was a type mismatch for this value` * while it might look like simply like a verbose rewording of `"invalid type"`, it actually would make it evident that the _value_ is wrong, not the _schema_ itself (which is what I mistakenly believed while debugging this). wdyt? Thanks - V

(6 评论) (0 反应) (0 负责人)Clojure (1,724 star) (237 fork)batch import

enhancementhelp wanted

描述

Hi!

The following:

(malli.error/humanize
 (malli.core/explain [:sequential :string] #{"a"}))

returns "invalid-type". That could be improved in a couple ways:

it could say expected :sequential, got :set
- i.e. mention the two specific types involved in the type mismatch.
additionally, or instead (for agility's sake), say there was a type mismatch for this value
- while it might look like simply like a verbose rewording of "invalid type", it actually would make it evident that the value is wrong, not the schema itself (which is what I mistakenly believed while debugging this).

wdyt?

Thanks - V

贡献者指南

技术栈: 无
领域: developer experience
议题类型: feature
难度: 2
预计时间: 1-3 hours
活动状态: active
清晰度: clear
前置要求: Clojure basicsMalli error handling
新手友好度: 85
研究方向: Look at the source code of `malli.error/humanize` and `malli.core/explain` to locate where the error message 'invalid type' is generated. Modify the error generation to include the expected type (e.g., :sequential) and the actual type (e.g., :set) as suggested in the issue. Also consider adding a clearer explanation that the mismatch is about the value, not the schema. Review the discussion in issue #750 for additional context and potential edge cases.