metosin/malli

malli.transform/-interceptor doesn’t support emptly-ish ?interceptor

Open

#596 创建于 2021年12月17日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Clojure (1,724 star) (237 fork)batch import
bughelp wanted

描述

https://github.com/metosin/malli/blob/152af3a3f8d59cca37a597b2403111bafbdee6ee/src/malli/transform.cljc#L36-L42

Hi,

I’m hitting a corner case with malli transform. I’m still trying to figure out why I’m hitting that corner case and what I can do to avoid that, but I think there’s also a robustness improvement that’s possible in malli.

When the keep function returns an empty list, the reduce function calls the anonymous function on line 38 with no arguments, and this fails.

One possible fix would be to make the anonymous function multi-arity and make it return nil when called with no arguments. Another possible fix would be to check the return value of keep, and only proceed with reducing it if it is a non-empty-list.

贡献者指南

技术栈
无
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Clojure knowledgeBasic understanding of reduce
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Look at the file src/malli/transform.cljc lines 36-42. The anonymous function passed to reduce is called with no arguments when `keep` returns an empty list, causing a failure. Two possible fixes are suggested: make the anonymous function multi arity to return nil when called with no arguments, or check the return value of `keep` and only reduce if it is non empty. Review the surrounding code and choose the simpler approach.