metosin/malli

Function generators return constant function if seed provided

Open

#1,039 创建于 2024年4月16日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Clojure (1,724 star) (237 fork)batch import
enhancementgeneratorhelp wanted

描述

This is because we use mg/generate to generate the return value, which always returns the same thing with the same seed.

(repeatedly 10 (mg/generate [:=> :cat :int]))
;=> (-480372 -103 7423 229 83 7937941 -4610 24 -1 21924979)
(repeatedly 10 (mg/generate [:=> :cat :int] {:seed 0}))
;=> (1784201 1784201 1784201 1784201 1784201 1784201 1784201 1784201 1784201 1784201)

;; even for different inputs
(mapv (mg/generate [:=> [:cat :int] :int] {:seed 0}) (range 10))
;=> [1784201 1784201 1784201 1784201 1784201 1784201 1784201 1784201 1784201 1784201]

贡献者指南

技术栈
无
领域
data
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Clojure basicsMalli library usage
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Examine the implementation of `mg/generate` in the malli source code, particularly how seeds are handled. Look for how the generator function is created and whether it inadvertently captures a fixed state from a single call to `mg/generate`. Suggest a fix that ensures each call to the generated function produces new values even when a seed is provided, possibly by re seeding internally or using a lazy sequence. Reference the file `src/metosin/malli/generator.cljc`.