metasfresh/metasfresh

Error message in Initial Setup Wizard if default partner metasfresh is set to inactive

Open

#4,955 创建于 2019年2月11日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Java (1,569 star) (548 fork)batch import
good first issuehelp wantedtype:enhancement

描述

Is this a bug or feature request?

FR

What is the current behavior?

users tend to set the partner "metasfresh" inactive leading the initial setup wizard to run into an exception.

trace:

{"timestamp":1549541958.280000000,"status":500,"error":"Internal Server
Error","exception":"org.adempiere.exceptions.AdempiereException","message":"NullPointerException:
java.lang.NullPointerException","trace":["org.adempiere.exceptions.AdempiereException:
NullPointerException: java.lang.NullPointerException","\tat
org.adempiere.exceptions.AdempiereException.wrapIfNeeded(AdempiereException.java:89)","\tat
de.metas.process.ProcessExecutionResult.propagateErrorIfAny(ProcessExecutionResult.java:717)","\tat
de.metas.process.JavaProcess.startProcess(JavaProcess.java:326)","\tat
de.metas.process.ProcessExecutor.startJavaProcess(ProcessExecutor.java:565)","\tat
de.metas.process.ProcessExecutor.startJavaOrScriptProcess(ProcessExecutor.java:461)","\tat
de.metas.process.ProcessExecutor.access$700(ProcessExecutor.java:51)","\tat
de.metas.process.ProcessExecutor$1.run(ProcessExecutor.java:225)","\tat
org.adempiere.ad.trx.api.impl.TrxCallableWrappers$3.call(TrxCallableWrappers.java:145)","\tat
org.adempiere.ad.trx.api.impl.TrxCallableWrappers$3.call(TrxCallableWrappers.java:135)","\tat
org.adempiere.ad.trx.api.impl.AbstractTrxManager.call0(AbstractTrxManager.java:776)","\tat
org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:689)","\tat
org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:590)","\tat
org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:521)","\tat
org.adempiere.ad.trx.api.impl.AbstractTrxManager.run(AbstractTrxManager.java:507)","\tat
de.metas.process.ProcessExecutor.executeNow(ProcessExecutor.java:287)","\tat
de.metas.process.ProcessExecutor.executeSync(ProcessExecutor.java:172)","\tat
de.metas.process.ProcessExecutor.access$1100(ProcessExecutor.java:51)","\tat
de.metas.process.ProcessExecutor$Builder.executeSync(ProcessExecutor.java:652)","\tat
de.metas.ui.web.process.adprocess.ADProcessInstanceController.executeADProcess(ADProcessInstanceController.java:333)","\tat
de.metas.ui.web.process.adprocess.ADProcessInstanceController.startProcess(ADProcessInstanceController.java:310)","\tat
de.metas.ui.web.process.ProcessRestController.lambda$null$8(ProcessRestController.java:262)","\tat
de.metas.ui.web.process.adprocess.ADProcessInstancesRepository.forProcessInstanceWritable(ADProcessInstancesRepository.java:420)","\tat
de.metas.ui.web.process.ProcessRestController.lambda$startProcess$9(ProcessRestController.java:261)","\tat
de.metas.ui.web.window.controller.Execution$ExecutionBuilder.lambda$execute$2(Execution.java:237)","\tat
de.metas.ui.web.window.controller.Execution$ExecutionBuilder.execute(Execution.java:260)","\tat
de.metas.ui.web.process.ProcessRestController.startProcess(ProcessRestController.java:260)","\tat
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)","\tat
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)","\tat
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)","\tat
java.lang.reflect.Method.invoke(Method.java:498)","\tat
org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)","\tat
org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:133)","\tat
org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:97)","\tat
org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:827)","\tat
org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:738)","\tat
org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)","\tat
org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:963)","\tat
org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:897)","\tat
org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:970)","\tat
org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:861)","\tat
javax.servlet.http.HttpServlet.service(HttpServlet.java:635)","\tat
org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:846)","\tat
javax.servlet.http.HttpServlet.service(HttpServlet.java:742)","\tat
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)","\tat
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)","\tat
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)","\tat
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)","\tat
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)","\tat
org.springframework.boot.web.filter.ApplicationContextHeaderFilter.doFilterInternal(ApplicationContextHeaderFilter.java:55)","\tat
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)","\tat
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)","\tat
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)","\tat
de.metas.ui.web.config.WebConfig$1.doFilter(WebConfig.java:82)","\tat
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)","\tat
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)","\tat
de.metas.ui.web.config.ServletLoggingFilter.doFilter(ServletLoggingFilter.java:89)","\tat
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)","\tat
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)","\tat
de.metas.ui.web.config.CORSFilter.doFilter(CORSFilter.java:79)","\tat
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)","\tat
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)","\tat
org.springframework.boot.actuate.trace.WebRequestTraceFilter.doFilterInternal(WebRequestTraceFilter.java:110)","\tat
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)","\tat
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)","\tat
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)","\tat
org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:99)","\tat
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)","\tat
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)","\tat
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)","\tat
org.springframework.web.filter.HttpPutFormContentFilter.doFilterInternal(HttpPutFormContentFilter.java:105)","\tat
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)","\tat
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)","\tat
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)","\tat
org.springframework.web.filter.HiddenHttpMethodFilter.doFilterInternal(HiddenHttpMethodFilter.java:81)","\tat
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)","\tat
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)","\tat
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)","\tat
org.springframework.session.web.http.SessionRepositoryFilter.doFilterInternal(SessionRepositoryFilter.java:167)","\tat
org.springframework.session.web.http.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:80)","\tat
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)","\tat
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)","\tat
org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:197)","\tat
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)","\tat
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)","\tat
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)","\tat
org.springframework.boot.actuate.autoconfigure.MetricsFilter.doFilterInternal(MetricsFilter.java:106)","\tat
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)","\tat
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)","\tat
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)","\tat
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)","\tat
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)","\tat
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)","\tat
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)","\tat
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)","\tat
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)","\tat
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)","\tat
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)","\tat
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)","\tat
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:861)","\tat
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)","\tat
org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)","\tat
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)","\tat
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)","\tat
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)","\tat
java.lang.Thread.run(Thread.java:748)","Caused by:
java.lang.NullPointerException","\tat
de.metas.bpartner.service.impl.BPartnerDAO.retrieveDefaultContactOrNull(BPartnerDAO.java:179)","\tat
de.metas.fresh.setup.process.ClientSetup.<init>(ClientSetup.java:133)","\tat
de.metas.fresh.setup.process.ClientSetup.newInstance(ClientSetup.java:80)","\tat
de.metas.fresh.setup.process.AD_Client_Setup.getClientSetup(AD_Client_Setup.java:129)","\tat
de.metas.fresh.setup.process.AD_Client_Setup.prepare(AD_Client_Setup.java:139)","\tat
de.metas.process.JavaProcess.prepareProcess(JavaProcess.java:700)","\tat
de.metas.process.JavaProcess.startProcess(JavaProcess.java:291)","\t...
102 more",""],"path":"/rest//api/process/ADP_540604/1004120/start"}

Which are the steps to reproduce?

set partner inactive run wizard and click ok

What is the expected or desired behavior?

either prevent setting the partner inactive or throw an error message that explains why the wizard can not be executed

贡献者指南

Error message in Initial Setup Wizard if default partner metasfresh is set to inactive · metasfresh/metasfresh#4955 | Good First Issue