metabase/metabase

selectors return new object every time causing unnecessary re-renderings

Open

#52,312 创建于 2025年1月17日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)Clojure (47,314 star) (6,465 fork)batch import
.Task.Team/Querying:broom:good first issue

描述

Context selectors return new object {verified: ..} so it's a new reference with every function call and it prevents memoization on reselect level.

  • getDefaultModelFilters
  • getDefaultMetricFilters

Selectors shouldn't return a different objects with the same arguments

贡献者指南

技术栈
javascripttypescript
领域
frontend
议题类型
performance
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic knowledge of JavaScriptfamiliarity with reselect
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
The issue identifies two selectors, getDefaultModelFilters and getDefaultMetricFilters, that return new objects on each call, breaking memoization. To fix, modify these selectors in the frontend codebase (likely in a file related to selectors, e.g., selectors.js or utils.js) to return cached or stable references when the same arguments are passed. Look for existing patterns in the codebase where selectors use reselect's createSelector with stable return values.
selectors return new object every time causing unnecessary re-renderings · metabase/metabase#52312 | Good First Issue