mesonbuild/meson

compiler.get_supported_arguments reports success for unsupported flags

Open

#5,355 创建于 2019年5月3日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Python (4,978 star) (1,465 fork)batch import
bugcompilersgood first issue

描述

The has_argument and get_supported_argument methods are reporting success when the compiler returns an unsupported flag error to stderr.

I have attached a simple test case which demonstrates the error. The relevant meson.log entry is

Running compile:
Working directory:  /tmp/tmpygkykj04
Command line:  c++ /tmp/tmpygkykj04/testfile.cpp -pipe -D_FILE_OFFSET_BITS=64 -c -o /tmp/tmpygkykj04/output.obj -O0 -fpermissive -Wdeclaration-after-statement 

Code:
 int i;

Compiler stdout:
 
Compiler stderr:
 cc1plus: warning: command line option '-Wdeclaration-after-statement' is valid for C/ObjC but not for C++

Compiler for C++ supports arguments -Wdeclaration-after-statement: YES

meson.build.txt

贡献者指南

技术栈
pythoncpp
领域
build systemtooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
PythonMeson internalsCompiler flags
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Review the compiler argument detection logic in mesonbuild/compilers/compilers.py, particularly the has argument and get supported arguments methods. The issue shows that for C++ compiler, the flag ' Wdeclaration after statement' is incorrectly reported as supported. Check if the code ignores stderr warnings. Also look at the attached meson.build test file and comment on how to differentiate between errors and warnings.