mesonbuild/meson

coverage targets ?

Open

#2,953 创建于 2018年1月19日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Python (4,978 star) (1,465 fork)batch import
buggood first issuehelp wanted

描述

I'm trying to close the issue #2805, and i'm discovering something strange:

  • ninja coverage -> call meson --internal
  • ninja coverage-html -> call lcov
  • ninja meson-coverage -> call meson --internal (coverage alias)
  • ninja meson-coverage-html -> call lcov (coverage-html alias)

The calls to lcov are currently implemented twice, in scripts/coverage.py and backends/ninjabackend.py. And the implementations are not the same…

That should be cleaned. One solution is to write only ninja targets:

  • coverage-html : call lcov, genhtml (just like in scripts/coverage.py)
  • coverage-txt : call gcovr
  • coverage-xml : call gcovr
  • coverage : depends on the 3 other targets.

EDIT : I'm seeing that the move went from ninja targets to meson internal script. Is there a reason ? Anyway, one would suppose meson-* targets will call meson --internal, and that's not the case.

贡献者指南

技术栈
python
领域
build system
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
understanding of Meson build systemfamiliarity with Pythonknowledge of ninja build tool
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue identifies duplicate implementations of lcov coverage commands in scripts/coverage.py and backends/ninjabackend.py. Start by examining both files to understand the current differences. Then propose a unified solution, such as creating ninja targets for coverage html, coverage txt, coverage xml, and a coverage alias that depends on them. Investigate why the move from ninja targets to meson internal scripts was made by checking related commits or issues. The solution should ensure consistency and possibly remove duplication.