mesonbuild/meson

State corruption with multiple tasks running on same directory

Open

#2,922 创建于 2018年1月14日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Python (4,978 star) (1,465 fork)batch import
buggood first issuehelp wanted

描述

I ran ninja -C build after changing some options. At the middle, or towards the end, I hit ^Z to check on something. After checking, I totally forgot that the job was already running, and started it again. Realizing I had done that, I killed the new job, and resumed the old one. I got:

$ nice ninja -j4 -C armv7-build 
ninja: Entering directory `armv7-build'
[0/1] Regenerating build files.
Error during basic setup:

Something went terribly wrong. Please file a bug.
FAILED: build.ninja 
/usr/bin/python3.6 /home/ilia/src/meson/meson.py --internal regenerate /home/ilia/src/mesa-meson /home/ilia/src/mesa-meson/armv7-build --backend ninja
ninja: error: rebuilding 'build.ninja': subcommand failed

Do I now have to wipe the whole build directory and all the things that were already built in it?

贡献者指南

技术栈
python
领域
build system
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of Meson build systemBasics of file locking and concurrency
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
The issue describes state corruption when two meson builds run concurrently in the same directory. Investigate file locking mechanisms used by Meson and Ninja, particularly around the build.ninja file and other intermediate files. Look at how Meson handles concurrent access and if there is any atomicity in file operations. Consider suggesting a lock file or a warning when a build directory is already in use. Review the Meson source code in mesonbuild/meson for relevant files like mesonbuild/mesonmain.py, backends/ninjabackend.py, and any state files.