mesonbuild/meson

Warn when build files use `object.path()` in places where `object` should be used

Open

#2,742 创建于 2017年12月6日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Python (4,978 star) (1,465 fork)batch import
enhancementhelp wantedparser/interpreter

描述

If script.sh exists, has a shebang but is not executable then the following two lines will case an error when trying to invoke the run target.

myscript = find_program('script.sh')
run_target('myscript', command : myscript.path())

I could not track down the exact cause of the problem. When meson searches for the program it will recognize that the file is not executable and look for the shebang. (It might be a good idea to warn about this on *nix platforms.) It then identifies the interpreter and creates an external program with the interpreter and the script file.

When trying to invoke the program in run_script_command the interpreter is lost and we fail to execute the non-executable script.

贡献者指南

技术栈
python
领域
build system
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
needs investigation
前置要求
Basic knowledge of Meson build systemPython debugging
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate how mesonbuild's find program and run target handle non executable scripts with shebangs. Look at the code in mesonbuild/interpreter.py or mesonbuild/program.py to trace the program detection logic. Consider adding a warning when a build file uses object.path() where object is a non executable script that was wrapped with an interpreter. Check linked comments for additional context.