mesonbuild/meson

vcs_tag() error output should be silenced if fallback is specified

Open

#2,240 创建于 2017年8月23日

在 GitHub 查看
 (12 评论) (0 反应) (0 负责人)Python (4,978 star) (1,465 fork)batch import
bughelp wanted

描述

meson's vcs_tag function is very useful but the fact that it always generates error output if no annotated tag matching the current git revision is found is... unnecessary.

We use actual git revisions as our version numbers for intermediate releases, so we provide the output of git rev-parse HEAD as the value of the fallback parameter to vcs_tag. That works great, but each time meson complains about no annotated tags:

ninja -C debug
ninja: Entering directory `debug'
[1/4] Generating GitVersion.cpp with a custom command.
fatal: No annotated tags can describe 'e5c806c6a0fc0380637b955b018485ccd1214ddd'.
However, there were unannotated tags: try --tags.

If a fallback is provided, I think that output should be silenced.

贡献者指南

技术栈
pythonshell
领域
build systemtooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic understanding of Meson build systemPython scripting
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
Locate the implementation of the vcs tag function in the Meson source code (likely in mesonbuild/interpreter.py or a similar module). Identify where the git command is executed and its output captured. Determine the condition under which a fallback is provided. Modify the code to suppress stderr output from the git command when a fallback is specified. Refer to the existing error handling patterns in the codebase, such as quiet flags on other commands. No linked PRs or recent comments provide a solution, so the task is to implement the feature as described.