meilisearch/MeiliSearch

Update docker image to expose `meilisearch` as the entry point rather than `tini`

开放

#2,229 创建于 2022年3月13日

 (8 条评论) (0 个反应) (0 位负责人)Rust (2,542 个派生)batch import
help wantedtooling

仓库指标

星标
 (57,572 个星标)
PR 合并指标
 (平均合并 11天 20小时) (30 天内合并 41 个 PR)

描述

Currently, Meilisearch exposes tini as the dockerfile entry point.

This creates a rather cryptic error when you try to run meili like normal e.g.

& docker run --name meilisearch -p 7700:7700 getmeili/meilisearch --master-key="foobar"

Produces:

[FATAL tini (7)] exec --master-key=foobar failed: No such file or directory

Which isn't the most helpful error in the world.

Either that or the documentation probably want's to be changed slightly to make it more clear that you need to explicitly re-run meili as:

& docker run --name meilisearch -p 7700:7700 getmeili/meilisearch ./meilisearch --master-key="foobar"

But IMO

getmeili/meilisearch ./meilisearch --master-key="foobar"

Doesn't seem to be the best situation.

贡献者指南