Destroy Menubar · max-mapper/menubar#281

2020-04-27T16:00:39.000Z

[//]: # "Hey there and thank you for using Menubar's issue tracker!" [//]: # "Please fill in these information to describe your issue." ### Description There is no API to destroy a menubar instance. I'm implementing a feature in my application which will allow the end-users to run their Electron app in a tray or a window, but there is no mechanism to tear-down a menubar. ### Steps to Reproduce the Problem 1. Create a menubar 2. Destroy Window Reference 3. `Error: Object has been destroyed: at Menubar. (my-app/node_modules/menubar/lib/Menubar.js:311:72)` ### Expected Behaviour I'd like for the menubar instance to have a teardown function ### Actual Behaviour There is no API to support this ### Specifications - Menubar version: 6.0.8 - Platform: Mac - Electron version: 7.1.9 ### Other information

(1 评论) (2 反应) (0 负责人)TypeScript (365 fork)github user discovery

good first issue

仓库指标

Star: (6,778 star)
PR 合并指标: (PR 指标待抓取)

描述

Description

There is no API to destroy a menubar instance. I'm implementing a feature in my application which will allow the end-users to run their Electron app in a tray or a window, but there is no mechanism to tear-down a menubar.

Steps to Reproduce the Problem

Create a menubar
Destroy Window Reference
Error: Object has been destroyed: at Menubar.<anonymous> (my-app/node_modules/menubar/lib/Menubar.js:311:72)

Expected Behaviour

I'd like for the menubar instance to have a teardown function

Actual Behaviour

There is no API to support this

Specifications

Menubar version: 6.0.8
Platform: Mac
Electron version: 7.1.9

Other information

贡献者指南

研究方向: 理解 Menubar 类的生命周期，并实现一个 destroy 方法，该方法能正确释放 BrowserWindow 和 Tray，移除事件监听器，并重置内部状态。
技术栈: typescriptnodejs
领域: desktop
议题类型: 功能
难度: 3
预计时间: 半天
活动状态: 活跃
清晰度: 清晰
前置要求: ElectronTypeScriptGit
新手友好度: 60