mattermost/mattermost

The HTML tag always has lang="en" even if the language in settings is set to a different language

Open

#26,672 创建于 2024年4月5日

在 GitHub 查看
 (26 评论) (2 反应) (1 负责人)TypeScript (32,880 star) (7,823 fork)batch import
Difficulty/1:EasyHelp WantedTech/ReactJS

描述

Original ticket: https://github.com/mattermost/mattermost-server/issues/21552

Summary

The html tag always defines the language of the page to <html lang="en">. We want this to be set to the “DefaultClientLocale”, that can be found in the config. If there is no value in the config, we can set it to unknown.

The objective of this is so browsers translate the content of the site (the messages in the posts) from the language the server is in theory using.

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-48048

贡献者指南

技术栈
typescriptreacthtml
领域
frontendaccessibilityinternationalization
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
familiarity with React and HTML templatesunderstanding of Mattermost config structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
The issue is to dynamically set the lang attribute on the <html> tag based on the DefaultClientLocale from the Mattermost config. The current code always sets lang="en". To start, search for where the HTML template is rendered (likely in the server rendered index.html or root component). Then locate where the config (DefaultClientLocale) is accessible, possibly via the Redux store or initial state. Review comments in the issue for any suggested approach. Reference the original server ticket for backend context. Ensure fallback to 'unknown' if config value is missing.