mattermost/mattermost

Padding on slash command menu items is too tight

Open

#24,042 创建于 2023年7月17日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (32,880 star) (7,823 fork)batch import
Help Wanted

描述

I’m not sure if/when this changed, but the vertical padding on slash command menu items seems too tight and there is not a clear vertical delineation between items because of it

Looks like the height is explicitly set to 4rem (which calculates to 40px). The height for slash command autocomplete items should be 4.8rem (48px) while other autocomplete items should stay as-is at 4rem (40px).

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-53600

贡献者指南

技术栈
typescriptcssreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
CSSReact
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
Locate the CSS rule that sets the height of slash command menu items to 4rem. This is likely in a styled component or CSS module related to the autocomplete component. Change the height to 4.8rem for slash command items while keeping other autocomplete items at 4rem. No other changes are needed. Refer to the autocomplete component files in the repository for the exact location.