mattermost/mattermost

RN: Improve Join Leave messages to only combine adjacent events of the same type and respect the order of events

Open

#23,196 创建于 2023年4月27日

在 GitHub 查看
 (4 评论) (0 反应) (1 负责人)TypeScript (32,880 star) (7,823 fork)batch import
Difficulty/2:MediumHelp WantedTech/React Native

描述

As in https://mattermost.atlassian.net/browse/MM-28338, we want join/leave messages on mobile to be grouped together as they are now, but we want to keep them in chronological order instead of grouping all join messages followed by all leave messages and so on.

Expected Behaviour:

  • System message should combine users with join, left, added, removed events on separate lines, in the order the events occur. We should keep the styling and copy of the messages as is, just change how they are ordered and grouped to respect the chronological order of events. For example:
3 joined
2 were removed
2 joined and left
3 joined
5 joined and left
4 were added by 
1 left

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-52545

贡献者指南

技术栈
reacttypescriptjavascript
领域
mobile
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React Native basicsTypeScript fundamentals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the current join/leave message grouping implementation in the React Native codebase, likely in components related to system messages (e.g., within `app/components/channel notice` or similar). Review the linked JIRA tickets (MM 28338, MM 52545) and any related PRs for context. The goal is to modify the grouping logic to combine only adjacent events of the same type while preserving chronological order, as described in the expected behavior. Start by locating the relevant code that handles join/leave event aggregation and update it to iterate through events in order, grouping consecutive same type events together.