mattermost-community/focalboard

Boards: try to attach image to card without permission shows wrong error msg

Open

#4,834 创建于 2023年3月30日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)TypeScript (26,187 star) (2,542 fork)user submission
Help WantedUp for grabs

描述

Summary

When viewing a card where you only have commenter permissions and trying to attach an image, the error message indicates the file size is too large (it isn't) instead of stating that you don't have permission.

Steps to reproduce

See screen shot

Expected behavior

Error message should state you do not have permission to attach a file.

Observed behavior (that appears unintentional)

attach_file_without_permissions

贡献者指南

技术栈
typescriptreact
领域
frontendauthorization
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic understanding of Reactfamiliarity with Focalboard's permission model
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Locate the file upload component in the webapp directory, likely under webapp/src/components/cardDetail. Look for the error handling logic that checks file size vs permissions. The fix involves showing the correct permission error message instead of the file size message when the user lacks permissions. Check any existing permission utilities or hooks to understand how user permissions are validated.