mattermost-community/focalboard

Bug: No card delete confirmation status for some cards

Open

#4,476 创建于 2023年1月17日

在 GitHub 查看
 (3 评论) (0 反应) (1 负责人)TypeScript (26,187 star) (2,542 fork)user submission
BugHelp WantedQA Verified

描述

Steps to reproduce the behavior

  1. Create a new card. Add some properties to it and set their values. Add some comments in there as well. Do not set the card title.
  2. Go back to kanban view and try deleting the card.
  3. Notice the UI didn't show any delete confirmation for this card.
  4. Create a new card and repeat step 1 but this time also set a card title.
  5. Go back to kanban view and try deleting the card. Notice that this time you see a delete confirmation.

Expected behavior

Card delete confirmation should show up if there is any data in the card.

Edition and Platform

  • Edition: Mattermost Boards (plugin)
  • Version: v7.8.0
  • Browser and OS: Firefox on MacOS

Additional context

The log in webapp is probably if the card has no title and no content, don't show the delete confirmation dialogue. It does not take into consideration the properties and comments in the card.

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React and TypeScript skillsFocalboard codebase familiarity
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The bug is in the delete confirmation logic likely within a component handling card deletion in the kanban view. Investigate the condition that determines whether to show the confirmation dialog; currently it only checks for title and content but ignores properties and comments. Look for files related to card actions, such as CardDetail or BoardCard, and update the condition to include all non empty data fields.