matrix-org/synapse

Add additional debug logging to MultiWriterIdGenerator.__init__ and get_cache_dict

开放

#9,443 创建于 2021年2月18日

 (1 条评论) (0 个反应) (0 位负责人)Python (2,196 个派生)batch import
O-OccasionalS-TolerableT-Taskgood first issue

仓库指标

星标
 (11,713 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

We should add debug logging to MultiWriterIdGenerator similar to that in StreamIdGenerator, per https://github.com/matrix-org/synapse/issues/9268#issuecomment-770190320:

If MultiWriterIdGenerator.__init__ and get_cache_dict included some logger.debug, this would be a lot less confusing to diagonose.

(I mention MultiWriterIdGenerator specifically, because StreamIdGenerator.__init__ does write debug, via _load_current_id, and it is quite helpful, and the inconsistency is extra confusing.)

贡献者指南