matrix-org/synapse

Third Party Lookups: the returned protocol instance icons are not Matrix Content URIs

Open

#4,175 创建于 2018年11月12日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Python (11,713 star) (2,196 fork)batch import
A-Spec-ComplianceS-MinorT-Defectgood first issue

描述

Contrary to the documentation (https://matrix.org/docs/spec/client_server/r0.4.0.html#get-matrix-client-r0-thirdparty-protocols), the returned protocol icons are not mxc:// URIs. The client gets https URLs (like "https://matrix.org/_matrix/media/v1/download/matrix.org/DHLHpDDgWNNejFmrewvwEAHX").

贡献者指南

技术栈
python
领域
backendapi
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Basic PythonUnderstanding of Matrix spec
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The issue describes that protocol instance icons are returned as https URLs instead of mxc:// URIs. To fix, locate the code in Synapse that handles third party protocol lookups (likely in synapse/rest/thirdparty.py or similar). Ensure that when returning protocol instance icons, the URI is an mxc:// URI as per the Matrix specification. This may involve converting the media URL to an MXC URI using the appropriate media repository API. No linked PRs exist, so the fix is independent.