matrix-org/synapse

Follow the spec regarding /client/r0/keys/changes

Open

#3,058 创建于 2018年4月3日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Python (11,713 star) (2,196 fork)batch import
A-Spec-ComplianceS-TolerableT-Defectgood first issue

描述

Description

Moving the discussion from the spec repo (https://github.com/matrix-org/matrix-doc/issues/1170).

A request to the endpoint will succeed even if it's missing the to query parameter which is marked as mandatory.

Steps to reproduce

curl -XGET "https://matrix.org/_matrix/client/r0/keys/changes?access_token=${TOKEN}&from=${NEXT_BATCH}"

Replacing TOKEN and NEXT_BATCH with a valid access token and a next_batch token returned by sync, respectively.

Expected behavior.

The endpoint should throw an error.

Version information

Tested with synapse v0.26 & with matrix.org

贡献者指南

技术栈
pythonrest api
领域
backendapi
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
PythonHTTP APIMatrix specSynapse codebase
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
Look at the implementation of the /keys/changes endpoint in Synapse (likely in synapse/rest/client/keys.py) to see how 'from' is validated but 'to' is not. Ensure 'to' is treated as mandatory as per the Matrix spec (matrix doc issue #1170). Add necessary validation similar to other required query parameters in the codebase.