matomo-org/matomo

Tracking code generator incorrectly sets domains for websites that use www in the hostname

Open

#19,844 创建于 2022年10月11日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)PHP (21,513 star) (2,847 fork)batch import
Help wanted

描述

When setting the URL for a website, we specify that it isn't necessary to specify URLs with and without www as Matomo handles both automatically. This means that people can set their URL to either www.example.org or to example.org: image

However, when the option "Track Visitors across all subdomains" is selected in the tracking code generator it incorrectly sets the domains and cookie domains to *.www.example.org when the website URL contains www: image

This can cause issues with the cookies on the websites tracked with things such as cookie consent tools that are quite strict and can cause issues with other things such as server-side tracking that relies on fetching the Visitor ID value from cookies

贡献者指南

技术栈
无
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
The bug is in the tracking code generator that constructs the ` paq.push(['setCookieDomain', ...])` and ` paq.push(['setDomains', ...])` lines. The code likely extracts the hostname without stripping the 'www.' prefix, resulting in incorrect wildcard domains. Look for files related to tracking code generation, such as in `plugins/Morpheus/templates/` or `core/Tracker/`. The fix should strip 'www.' from the hostname before generating the domain strings. Review the existing logic for handling URLs with 'www' and ensure the subdomain wildcard is applied to the bare domain.