matomo-org/matomo

The newly added daily mail report cannot be sent on the same day！

Open

#18,378 创建于 2021年11月25日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)PHP (21,513 star) (2,847 fork)batch import
BugHelp wanted

描述

The newly added daily mail report cannot be sent on the same day!

Steps to Reproduce

  1. Add a new daily email report, such as 4:00 pm (current 2:00 pm)
  2. No email report will be sent at 4:00 pm on the same day
  3. Check TasksTimetable to find the task at 4:00 pm the next day

Environment

  • Matomo Version: 4.5.0
  • PHP Version: 7.4

image

贡献者指南

技术栈
无
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic PHPUnderstanding of cron/scheduling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
Investigate the scheduling logic in Matomo's TasksTimetable implementation. The bug is that new daily email reports are scheduled for the next day instead of the same day if added after the scheduled time. Look for a function that calculates the next run time for scheduled tasks, possibly in a file like 'core/TasksTimetable.php'. Check if there is a comparison of the current time with the scheduled time, and ensure that if the scheduled time is later in the day, the task should execute today. The fix might involve adjusting a condition or adding a check for same day scheduling when the scheduled time is after the current time.
The newly added daily mail report cannot be sent on the same day！ · matomo-org/matomo#18378 | Good First Issue