matomo-org/matomo

Redis cache: Prepend Matomo version number to cache key, and enforce a TTL

Open

#14,314 创建于 2019年4月4日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)PHP (21,513 star) (2,847 fork)batch import
BugHelp wanted

描述

In https://matomo.org/faq/how-to/faq_20511/ we recommend to use the Redis cache when using multiple servers to run Matomo. This can result in many issues though eg when each server has a different path to the Matomo directory.

Also when updating Matomo on the servers, in most cases some servers will run a new Matomo version while other servers will run an older version of Matomo. Yet they all access the same cache. This is problematic because caches aren't compatible between Matomo versions, and they have different files etc. Meaning while deploying code (in for us takes sometimes 30min+ to update all servers) Matomo can be broken if someone uses redis cache. To workaround this issue we could prepend the Matomo version number to all cache IDs. To still invalidate the cache entries of older Matomo versions, we need to make sure that when a cache is saved with no TTL, we need to set eg 86400 to free space after a while.

I will mention in the FAQ that redis cache can only be used if they all have the same path.

贡献者指南

技术栈
phpredis
领域
backendperformance
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
PHPRedisMatomo caching
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
55
研究方向
Investigate the existing cache implementation in Matomo, particularly the Redis cache adapter, to understand how cache keys are currently generated. Look for the relevant files in the plugins/Core or libs/ directory. Add logic to prepend the Matomo version number to all cache IDs and enforce a TTL of 86400 seconds for entries without an explicit TTL. Review the comments in the issue for any additional context on compatibility.