mapbox/mapbox-gl-js

v1.10.0-beta.1 - No way to disable new "tap then drag" to zoom gesture

Open

#9,584 创建于 2020年4月17日

在 GitHub 查看
 (1 评论) (4 反应) (1 负责人)JavaScript (10,532 star) (2,203 fork)batch import
feature :green_apple:good first issue

描述

The TouchZoomRotateHandler support various gestures ("zoom rotate", "pinch zoom/touch zoom", "single finger zoom/tap then drag"), however it only allows you to disable the "zoom rotate" gesture.

The individual gestures can be disabled by diving in to the private members (such as by calling "map.touchZoomRotate._tapDragZoom.disable();").

It would be nicer to have a match for disableRotation()/enableRotation() to turn on/off each supported gesture (i.e. add a disableTapZoom()/enableTapZoom()).

贡献者指南

技术栈
javascript
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Familiarity with Mapbox GL JS APIUnderstanding of gesture handling in WebGL maps
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the existing TouchZoomRotateHandler to understand how disableRotation/enableRotation are implemented. Look at the private tapDragZoom property and its disable/enable methods. Consider adding similar public methods disableTapZoom/enableTapZoom following the same pattern. Check for any ongoing discussions in the issue comments or related PRs.