mapbox/mapbox-gl-js

getStyle then setStyle broken for raster-dem

Open

#8,506 创建于 2019年7月18日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (10,532 star) (2,203 fork)batch import
bug :lady_beetle:good first issue

描述

mapbox-gl-js version: tested on 1.1.0, probably since forever

browser: Chrome 75.0.3770.100 (Official Build) (64-bit)

Steps to Trigger Behavior

  1. setStyle on a style with raster-dem source
  2. getStyle anytime
  3. setStyle with serialized style object from getStyle

Link to Demonstration

https://jsfiddle.net/srmanc/L20ha5um/1/

Expected Behavior

setStyle should work without error msgs

Actual Behavior

setStyle breaks because bounds and url are set on source but are undefined. Sometimes tiles is undefined on source as well. There are actually two issues:

  1. Why does setStyle break at all if some undefined properties are set on source (this only happens for raster-dem type).
  2. When is it acceptable to call getStyle() to get all the relevant properties on sources - they are set initially so there would be no point in not setting them right away - however, tiles property is missing at the first "styledata" event - please review the jsfiddle example with console.log msgs for more input. We can make this work using delete operator but this seems like a nasty bug.

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptMapbox GL JS style spec
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Investigate how raster dem source properties (bounds, url, tiles) are serialized in getStyle and deserialized in setStyle. Look at source/style.js where style methods are defined. Check how tile source properties are set during style loading. Consider using delete operator on undefined properties as a workaround but ensure proper handling in setStyle.