mapbox/mapbox-gl-js

Symbol interpolation issue when icon-pitch-alignment is "map"

Open

#8,110 创建于 2019年4月2日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (10,532 star) (2,203 fork)batch import
bug :lady_beetle:good first issue

描述

mapbox-gl-js version: v0.54.0-beta.1

browser: any

Steps to Trigger Behavior

  1. create a symbol layer with icon-pitch-alignment set to "map"
  2. do not rotate or pitch the map

Expected Behavior

Icon should be rendered with NEAREST interpolation

Actual Behavior

Icon is rendered with LINEAR interpolation

Hint: there is a condition in draw_symbol.js:197

pitchWithMap || tr.pitch !== 0

I think it should be just

tr.pitch !== 0

because when icon-pitch-alignment is set to "map", and neither the icon nor the map is rotated, NEAREST should be used. (same as "viewport" alignment)

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptmapbox gl js symbol layers
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
The bug is in draw symbol.js at line 197, where the condition `pitchWithMap || tr.pitch !== 0` should be changed to `tr.pitch !== 0`. This ensures NEAREST interpolation is used when icon pitch alignment is 'map' and the map is not pitched. The issue has no linked pull requests, so the fix is straightforward and well documented. Review the symbol rendering code in draw symbol.js to implement the change and verify with a test case.