mapbox/mapbox-gl-js

Expose a "statechange" event on GeolocateControl

Open

#5,136 创建于 2017年8月11日

在 GitHub 查看
 (0 评论) (2 反应) (0 负责人)JavaScript (10,532 star) (2,203 fork)batch import
feature :green_apple:good first issue

描述

Motivation

Discussion started here: https://github.com/mapbox/mapbox-gl-js/pull/4479#issuecomment-321203924

The GeolocateControl doesn't expose events necessary to act on all of its states. trackuserlocationstart and trackuserlocationend aren't enough to detect some user actions. For instance, it's impossible to know if the user toggled off tracking.

To achieve this I currently have to use a MutationObserver on the .mapboxgl-ctrl-geolocate watching for classList changes.

Design

Fire a new statechange event on every _watchState change and pass along its value.

Implementation

Replace all this._watchState = ... with:

_setState(state) => {
  if (this._watchState !== state) {
    this._watchState = state
    this.fire('statechange', state)

    // ... conditions logic to fire trackuserlocationstart and trackuserlocationend
  
    // bonus?
    this._updateUI(state) // centralize the different classList updates spread in _onSucces, _onError, _onClick...
  }
}

贡献者指南

Expose a "statechange" event on GeolocateControl · mapbox/mapbox-gl-js#5136 | Good First Issue