mapbox/mapbox-gl-js

map.fitBounds() with bearing does not fit the entire bounds

Open

#10,064 创建于 2020年11月1日

在 GitHub 查看
 (7 评论) (0 反应) (0 负责人)JavaScript (10,532 star) (2,203 fork)batch import
bug :lady_beetle:good first issue

描述

When map.fitBounds(...) is called with a bearing option passed in, it seems like the bearing is not taken into the account on calculating the appropriate zoom, resulting in part of the bounded area to not be in view.

mapbox-gl-js version: 1.12.0

browser: Chrome

Steps to Trigger Behavior

  1. Create a bounded area with a list of coordinates
  2. Call map.fitBounds(...) with bearing option set

Link to Demonstration

https://jsfiddle.net/_blahblahblah/k4vL6s5r/

Expected Behavior

When clicking on the 'Fit to Line at 29º Bearing' button in the demo link, all 6 stations should be in view.

Actual Behavior

Only 4 of the 6 stations are in view.

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of mapbox gl js APIBasic geometry for map boundsJavaScript proficiency
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the `fitBounds` implementation in the Mapbox GL JS source code (likely in `src/ui/map.js`). The calculation for zoom level does not account for bearing, causing bounds to be partially visible. Consider modifying the algorithm to compute the bounding box after applying the rotation, or use a different method to ensure all points are within the viewport. Review comments in the issue for any suggested fixes or related PRs.