FeatureLevelRemove- and SourceLevelRemove-Benchmarks in remove_paint_state.js are exactly the same · mapbox/mapbox-gl-js#10049

(0 评论) (0 反应) (0 负责人)JavaScript (10,532 star) (2,203 fork)batch import

good first issue

描述

Unless I'm missing something, both benchmarks were already the same when they were added in #7761 by @peterqliu :

I haven't used these APIs yet, but I believe the SourceLevelRemove should have used something like this?

// No loop
this.map.removeFeatureState({source: 'land'});

Maybe also source-property level like this?

// No loop
this.map.removeFeatureState({source: 'land'}, 'bench');

技术栈: javascript
领域: performancetesting
议题类型: test
难度: 2
预计时间: under 1 hour
活动状态: stale
清晰度: clear
前置要求: JavaScriptmapbox gl js API
新手友好度: 70
研究方向: The issue identifies that the FeatureLevelRemove and SourceLevelRemove benchmarks in bench/benchmarks/remove paint state.js (lines 88-100 and 102-114) are identical, which is likely a copy paste error. The SourceLevelRemove benchmark should use `map.removeFeatureState({source: 'land'})` instead of looping over features. Review the mapbox gl js API documentation for `removeFeatureState` and consider whether a source property level removal (e.g., `map.removeFeatureState({source: 'land'}, 'bench')`) is more appropriate. The fix involves modifying the SourceLevelRemove benchmark function to replace the loop with the correct API call, ensuring it tests the intended functionality. After making the change, run the benchmarks to verify correctness.