lsd-rs/lsd

Add `ls_colors` option to theme

Open

#608 创建于 2022年1月17日

在 GitHub 查看
 (2 评论) (4 反应) (0 负责人)Rust (13,400 star) (434 fork)batch import
area/themegood first issuekind/enhancement

描述

As of now, we support theme for colors, and still use ls_colors for file name colors, how about adding the ls_colors option to the theme configuration file, and so that we can configure all the colors in one place.

also, there is something that needs to be covered:

  1. the ls_colors in the theme should be optional, and fall back to LS_COLORS env
  2. the one in themes should overwrite the env one

@meain

贡献者指南

技术栈
rust
领域
cli
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Rust programmingFamiliarity with lsd's theme configurationUnderstanding of LS COLORS environment variable
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
Explore the current theme configuration implementation in the lsd source code, particularly how colors are handled. The issue suggests adding an `ls colors` field to the theme struct (likely in src/theme.rs or similar). Ensure the new option is optional and falls back to the `LS COLORS` environment variable. Check if there are any existing tests for theme parsing that need updating.