Misleading grid / column output in some cases · lsd-rs/lsd#594

(3 评论) (1 反应) (0 负责人)Rust (13,400 star) (434 fork)batch import

good first issuekind/enhancement

描述

os: macOS Monterey (12.0.1)
lsd --version: lsd 0.20.1 (also checked version built from https://github.com/Peltoche/lsd.git?branch=master#0a3a6f10)
echo $TERM: xterm-256color
echo $LS_COLORS: Empty / uninitialized

Expected behavior

With some long filenames in a directory, columnar output (the default?) can become misleading. Would be preferable to replicate the output of GNU ls in this case. The little video below shows both the expected and actual behaviors.

Actual behavior

Please see the video. In it, file_16 goes into column 2, and off-screen (!) making it seem like there are no more files beyond file_15_....

To reproduce this, you need this:

# Set terminal window's size to 14 rows & 91 columns
$ seq -f "file_%02g" 00 16 | xargs touch
$ mv file_00 file_00_abcdefghijklmnopqrstuvwxyz_abcdefghiklmnopqrstuvwxyz
$ mv file_15 file_15_abcdefghijklmnopqrstuvwxyz_abcdefghiklmnopqrstuvwxyz

This happens at all sizes of the terminal window. I've reduced it here, to make it easier to reproduce.

https://user-images.githubusercontent.com/172235/144849060-cfcd8286-cfd1-4dde-a699-43c8e1900c28.mp4

贡献者指南

技术栈: rust
领域: cli
议题类型: bug
难度: 3
预计时间: 1-3 hours
活动状态: stale
清晰度: mostly clear
前置要求: Basic RustUnderstanding of terminal layout
新手友好度: 50
研究方向: Investigate the grid/column layout logic in the source code, likely in src/display.rs or a related module. Focus on how column widths are calculated and how long filenames cause misalignment. Look at the term grid crate usage to understand the expected behavior. Consider adjusting the column count or adding truncation logic.