Distinguish TimeoutErrors for open and read timeouts · lostisland/faraday#718

(33 评论) (1 反应) (0 负责人)Ruby (5,861 star) (997 fork)batch import

featurehelp wanted

描述

In faraday/adapter/rack.rb, TimeoutError is raised for both open and read timeouts:

timeout  = env[:request][:timeout] || env[:request][:open_timeout]
response = if timeout
  Timer.timeout(timeout, Faraday::Error::TimeoutError) { execute_request(env, rack_env) }
else ... end

According to https://stackoverflow.com/questions/10322283/what-is-timeout-and-open-timeout-in-faraday, open_timeout is for the tcp connection and timeout is for the response read.

It would be nice to have separate exception types for these timeouts. Then we could determine whether or not to retry the request. Does adding something like Faraday::Error::OpenTimeoutError and Faraday::Error::ResponseTimeoutError and using those here make sense?

贡献者指南

技术栈: ruby
领域: backendapi
议题类型: feature
难度: 3
预计时间: 1-3 hours
活动状态: needs maintainer response
清晰度: clear
前置要求: RubyFaraday basicsHTTP timeout concepts
新手友好度: 60
研究方向: Examine the existing error hierarchy in Faraday, specifically Faraday::Error::TimeoutError. Consider adding two new exception classes: OpenTimeoutError and ResponseTimeoutError inheriting from TimeoutError. Update faraday/adapter/rack.rb to use the appropriate exception for open timeout and read timeout. Also check other adapters (e.g., net http) for similar patterns. Review comments in the issue for any discussion on naming or implementation details.