lostisland/faraday

Requests can no longer be converted to simple JSON

Open

#535 创建于 2015年10月13日

在 GitHub 查看
 (8 评论) (0 反应) (0 负责人)Ruby (5,861 star) (997 fork)batch import
featurehelp wanted

描述

fba7ce503d2be7bd88229f95107559a14c98821c causes a stack too deep to occur when attempting to call to_json, due to the nested env/request nature of the objects.

Some context: We have been logging the json version of faraday response objects for verification purposes when performing sensitive data changes through faraday requests; This is no longer possible.

贡献者指南

技术栈
无
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Ruby knowledgeunderstanding of Faraday response objects
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate commit fba7ce503d2be7bd88229f95107559a14c98821c which introduced the nesting causing stack overflow. Look at the `to json` method in Faraday's response object and determine how to serialize without infinite recursion. Consider adding a custom `as json` or `to json` override that excludes the `env`/`request` parts or uses a depth limit.
Requests can no longer be converted to simple JSON · lostisland/faraday#535 | Good First Issue