localForage/localForage

Make "name" optional in config when driver = localstorage

Open

#641 创建于 2017年1月6日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (24,184 star) (1,260 fork)batch import
bugdocshelp wantedquestion

描述

I am trying to read key "counter" from localstorage, but can't, because it tries to read "/counter" if I set name to "". If I set name to "whatever" it reads "whatever/counter". Can you change line 20 in localForage/src/drivers/localstorage.js from dbInfo.keyPrefix = dbInfo.name + '/'; to something like dbInfo.keyPrefix = (dbInfo.name && dbInfo.name != "") ? dbInfo.name + '/' : '';

贡献者指南

技术栈
javascript
领域
frontenddatabase
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptlocalStorage knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The issue suggests modifying line 20 in localForage/src/drivers/localstorage.js to make the 'name' config optional when driver is localStorage. The fix is to change the line that sets dbInfo.keyPrefix to conditionally append '/' only if name is non empty. After implementing, test with various name values (empty string, undefined, and a valid name) to ensure keyPrefix is set correctly. Also check if there are any existing tests that might need updating.
Make "name" optional in config when driver = localstorage · localForage/localForage#641 | Good First Issue