llvm/llvm-project

Add option to readability-implicit-bool-conversion check to allow implicit conversion *to bool*

Open

#36,323 创建于 2018年4月2日

在 GitHub 查看
 (4 评论) (0 反应) (1 负责人)C++ (26,378 star) (10,782 fork)batch import
bugzillaclang-tidyenhancementgood first issue

描述
Bugzilla Link 36975
Version unspecified
OS All
Reporter LLVM Bugzilla Contributor

Extended Description

From the readability-implicit-bool-conversion check, I'd like to take advantage of these parts:

  • boolean expression/literal to integer,
  • boolean expression/literal to floating.

But not these:

  • integer expression/literal to boolean,
  • floating expression/literal to boolean,
  • pointer/pointer to member/nullptr/NULL to boolean,

Seems like an AllowConversionsToBool option would take care of this. Maybe for completeness/symmetry also a AllowConversionsFromBool option. Both defaulting to 0.

贡献者指南

技术栈
cpp
领域
tooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C++ knowledgeclang tidy development setupunderstanding of readability implicit bool conversion check
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
The issue requests adding options to the readability implicit bool conversion check in clang tidy. Start by examining the existing check implementation in clang tools extra/clang tidy/readability/ImplicitBoolConversionCheck.cpp. Look for current option handling and add two new boolean options: AllowConversionsToBool and AllowConversionsFromBool. Modify the check logic to suppress warnings based on these options. Update the check's documentation and add test cases in clang tools extra/test/clang tidy/checkers/readability implicit bool conversion.cpp. Review comments from the issue for additional context.