llvm/llvm-project

Readability check for position of constant operand in binary operators

Open

#31,860 创建于 2017年4月3日

在 GitHub 查看
 (13 评论) (0 反应) (1 负责人)C++ (26,378 star) (10,782 fork)batch import
bugzillacheck-requestclang-tidygood first issue

描述
Bugzilla Link 32513
Version unspecified
OS All

Extended Description

Will be good idea to have readability check for position of constant operand in binary operators.

For example:

if (nullptr == Pointer)

should be fixed as

if (Pointer == nullptr)

or

if (0 < Value)

to

if (Value > 0)

贡献者指南

技术栈
cpp
领域
tooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
C++ experienceAST matchersclang tidy infrastructure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Examine existing clang tidy readability checks for similar patterns (e.g., readability const return type). Study the AST matcher API for BinaryOperator and understand how to check the position of constant operands. Review the LLVM coding standards for operator precedence and discuss on the issue thread to clarify the scope. Look at the issue's comments for any additional requirements or suggestions.