ljharb/qs

square brackets confuse the parser

Open

#513 创建于 2024年10月10日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)JavaScript (8,015 star) (744 fork)batch import
bughelp wantedparsestringify

描述

Hello, while parsing a body like the following, qs fails:

buttons[commands.identifier_orders_merge_action|{"orders":["47441","47440"]}]=Unisci+ordini

This becomes something like:

'buttons[commands.identifier_orders_merge_action|{"orders":': { '"47441","47440"': 'Unisci ordini' }

while it should be something more similar to this:

'buttons[commands.identifier_orders_merge_action|{"orders":{ '"47441","47440"}]': 'Unisci ordini'

贡献者指南

技术栈
javascript
领域
backendapi
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Investigate the parsing logic in the qs library, likely in the `lib/parse.js` file, to understand how square brackets and nested JSON strings are tokenized. Look for existing tests related to bracket parsing and consider adding a test case that reproduces the issue with a query string containing JSON with brackets. The fix may involve adjusting the regex or the state machine that identifies keys and values. Review any linked issues or comments for additional context.